refactor: remove deprecated memory_window, harden wizard display

tests/test_commands.py

@@ -452,14 +452,15 @@ def test_agent_workspace_override_wins_over_config_workspace(mock_agent_runtime,
     assert mock_agent_runtime["agent_loop_cls"].call_args.kwargs["workspace"] == workspace_path
 
 
-def test_agent_warns_about_deprecated_memory_window(mock_agent_runtime):
-    mock_agent_runtime["config"].agents.defaults.memory_window = 100
+def test_agent_hints_about_deprecated_memory_window(mock_agent_runtime, tmp_path):
+    config_file = tmp_path / "config.json"
+    config_file.write_text(json.dumps({"agents": {"defaults": {"memoryWindow": 42}}}))
 
-    result = runner.invoke(app, ["agent", "-m", "hello"])
+    result = runner.invoke(app, ["agent", "-m", "hello", "-c", str(config_file)])
 
     assert result.exit_code == 0
     assert "memoryWindow" in result.stdout
-    assert "contextWindowTokens" in result.stdout
+    assert "no longer used" in result.stdout
 
 
 def test_gateway_uses_workspace_from_config_by_default(monkeypatch, tmp_path: Path) -> None:
@@ -523,28 +524,6 @@ def test_gateway_workspace_option_overrides_config(monkeypatch, tmp_path: Path)
     assert config.workspace_path == override
 
 
-def test_gateway_warns_about_deprecated_memory_window(monkeypatch, tmp_path: Path) -> None:
-    config_file = tmp_path / "instance" / "config.json"
-    config_file.parent.mkdir(parents=True)
-    config_file.write_text("{}")
-
-    config = Config()
-    config.agents.defaults.memory_window = 100
-
-    monkeypatch.setattr("nanobot.config.loader.set_config_path", lambda _path: None)
-    monkeypatch.setattr("nanobot.config.loader.load_config", lambda _path=None: config)
-    monkeypatch.setattr("nanobot.cli.commands.sync_workspace_templates", lambda _path: None)
-    monkeypatch.setattr(
-        "nanobot.cli.commands._make_provider",
-        lambda _config: (_ for _ in ()).throw(_StopGatewayError("stop")),
-    )
-
-    result = runner.invoke(app, ["gateway", "--config", str(config_file)])
-
-    assert isinstance(result.exception, _StopGatewayError)
-    assert "memoryWindow" in result.stdout
-    assert "contextWindowTokens" in result.stdout
-
 def test_gateway_uses_config_directory_for_cron_store(monkeypatch, tmp_path: Path) -> None:
     config_file = tmp_path / "instance" / "config.json"
     config_file.parent.mkdir(parents=True)

tests/test_config_migration.py

@@ -3,7 +3,7 @@ import json
 from nanobot.config.loader import load_config, save_config
 
 
-def test_load_config_keeps_max_tokens_and_warns_on_legacy_memory_window(tmp_path) -> None:
+def test_load_config_keeps_max_tokens_and_ignores_legacy_memory_window(tmp_path) -> None:
     config_path = tmp_path / "config.json"
     config_path.write_text(
         json.dumps(
@@ -23,7 +23,7 @@ def test_load_config_keeps_max_tokens_and_warns_on_legacy_memory_window(tmp_path
 
     assert config.agents.defaults.max_tokens == 1234
     assert config.agents.defaults.context_window_tokens == 65_536
-    assert config.agents.defaults.should_warn_deprecated_memory_window is True
+    assert not hasattr(config.agents.defaults, "memory_window")
 
 
 def test_save_config_writes_context_window_tokens_but_not_memory_window(tmp_path) -> None:
@@ -52,7 +52,7 @@ def test_save_config_writes_context_window_tokens_but_not_memory_window(tmp_path
     assert "memoryWindow" not in defaults
 
 
-def test_onboard_refresh_rewrites_legacy_config_template(tmp_path, monkeypatch) -> None:
+def test_onboard_does_not_crash_with_legacy_memory_window(tmp_path, monkeypatch) -> None:
     config_path = tmp_path / "config.json"
     workspace = tmp_path / "workspace"
     config_path.write_text(
@@ -78,12 +78,6 @@ def test_onboard_refresh_rewrites_legacy_config_template(tmp_path, monkeypatch)
     result = runner.invoke(app, ["onboard"], input="n\n")
 
     assert result.exit_code == 0
-    assert "contextWindowTokens" in result.stdout
-    saved = json.loads(config_path.read_text(encoding="utf-8"))
-    defaults = saved["agents"]["defaults"]
-    assert defaults["maxTokens"] == 3333
-    assert defaults["contextWindowTokens"] == 65_536
-    assert "memoryWindow" not in defaults
 
 
 def test_onboard_refresh_backfills_missing_channel_fields(tmp_path, monkeypatch) -> None:

tests/test_consolidate_offset.py

@@ -182,7 +182,7 @@ class TestConsolidationTriggerConditions:
     """Test consolidation trigger conditions and logic."""
 
     def test_consolidation_needed_when_messages_exceed_window(self):
-        """Test consolidation logic: should trigger when messages > memory_window."""
+        """Test consolidation logic: should trigger when messages exceed the window."""
         session = create_session_with_messages("test:trigger", 60)
 
         total_messages = len(session.messages)