From b721f9f37dc295d30d45e81746335ae34b54f5e1 Mon Sep 17 00:00:00 2001
From: Alexander Minges <alexander.minges@uni-due.de>
Date: Tue, 10 Feb 2026 12:24:54 +0100
Subject: [PATCH] test(matrix): cover response callbacks and graceful shutdown

---
 tests/test_matrix_channel.py | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/tests/test_matrix_channel.py b/tests/test_matrix_channel.py
index bc39097..f86543b 100644
--- a/tests/test_matrix_channel.py
+++ b/tests/test_matrix_channel.py
@@ -14,6 +14,12 @@ class _DummyTask:
     def cancel(self) -> None:
         self.cancelled = True
 
+    def __await__(self):
+        async def _done():
+            return None
+
+        return _done().__await__()
+
 
 class _FakeAsyncClient:
     def __init__(self, homeserver, user, store_path, config) -> None:
@@ -25,15 +31,23 @@ class _FakeAsyncClient:
         self.access_token: str | None = None
         self.device_id: str | None = None
         self.load_store_called = False
+        self.stop_sync_forever_called = False
         self.join_calls: list[str] = []
         self.callbacks: list[tuple[object, object]] = []
+        self.response_callbacks: list[tuple[object, object]] = []
 
     def add_event_callback(self, callback, event_type) -> None:
         self.callbacks.append((callback, event_type))
 
+    def add_response_callback(self, callback, response_type) -> None:
+        self.response_callbacks.append((callback, response_type))
+
     def load_store(self) -> None:
         self.load_store_called = True
 
+    def stop_sync_forever(self) -> None:
+        self.stop_sync_forever_called = True
+
     async def join(self, room_id: str) -> None:
         self.join_calls.append(room_id)
 
@@ -81,10 +95,28 @@ async def test_start_skips_load_store_when_device_id_missing(
 
     assert len(clients) == 1
     assert clients[0].load_store_called is False
+    assert len(clients[0].response_callbacks) == 3
 
     await channel.stop()
 
 
+@pytest.mark.asyncio
+async def test_stop_stops_sync_forever_before_close(monkeypatch) -> None:
+    channel = MatrixChannel(_make_config(device_id="DEVICE"), MessageBus())
+    client = _FakeAsyncClient("", "", "", None)
+    task = _DummyTask()
+
+    channel.client = client
+    channel._sync_task = task
+    channel._running = True
+
+    await channel.stop()
+
+    assert channel._running is False
+    assert client.stop_sync_forever_called is True
+    assert task.cancelled is False
+
+
 @pytest.mark.asyncio
 async def test_room_invite_joins_when_allow_list_is_empty() -> None:
     channel = MatrixChannel(_make_config(allow_from=[]), MessageBus())