Hua/nanobot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(matrix): use milliseconds for typing timing constants

Browse Source
This commit is contained in:
Alexander Minges
2026-02-21 20:29:47 +01:00
parent de5104ab2a
commit 494fa8966a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nanobot/channels/matrix.py
View File

@@ -43,7 +43,7 @@ TYPING_NOTICE_TIMEOUT_MS = 30_000
# https://spec.matrix.org/v1.17/client-server-api/#typing-notifications # https://spec.matrix.org/v1.17/client-server-api/#typing-notifications
# Keepalive interval must stay below TYPING_NOTICE_TIMEOUT_MS so the typing # Keepalive interval must stay below TYPING_NOTICE_TIMEOUT_MS so the typing
# indicator does not expire while the agent is still processing. # indicator does not expire while the agent is still processing.
TYPING_KEEPALIVE_INTERVAL_SECONDS = 20.0 TYPING_KEEPALIVE_INTERVAL_MS = 20_000
MATRIX_HTML_FORMAT = "org.matrix.custom.html" MATRIX_HTML_FORMAT = "org.matrix.custom.html"
MATRIX_ATTACHMENT_MARKER_TEMPLATE = "[attachment: {}]" MATRIX_ATTACHMENT_MARKER_TEMPLATE = "[attachment: {}]"
MATRIX_ATTACHMENT_TOO_LARGE_TEMPLATE = "[attachment: {} - too large]" MATRIX_ATTACHMENT_TOO_LARGE_TEMPLATE = "[attachment: {} - too large]"
@@ -715,7 +715,7 @@ class MatrixChannel(BaseChannel):
async def _typing_loop() -> None: async def _typing_loop() -> None:
try: try:
while self._running: while self._running:
await asyncio.sleep(TYPING_KEEPALIVE_INTERVAL_SECONDS) await asyncio.sleep(TYPING_KEEPALIVE_INTERVAL_MS / 1000)
await self._set_typing(room_id, True) await self._set_typing(room_id, True)
except asyncio.CancelledError: except asyncio.CancelledError:
pass pass

2
tests/test_matrix_channel.py
View File

@@ -332,7 +332,7 @@ async def test_typing_keepalive_refreshes_periodically(monkeypatch) -> None:
channel.client = client channel.client = client
channel._running = True channel._running = True
monkeypatch.setattr(matrix_module, "TYPING_KEEPALIVE_INTERVAL_SECONDS", 0.01) monkeypatch.setattr(matrix_module, "TYPING_KEEPALIVE_INTERVAL_MS", 10)
await channel._start_typing_keepalive("!room:matrix.org") await channel._start_typing_keepalive("!room:matrix.org")
await asyncio.sleep(0.03) await asyncio.sleep(0.03)